This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Test for a Module class before testing for a class named after the module
#73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…module Per zendframework#5, non-namespaced classes can create issues within applications if they conflict with a module. In particular, `Generator` is one (as the class is non-instantiable via `new`), but this can also happen in legacy applications where a new module may exist under the same name as a defined class. This patch adds tests to ensure that the resolver prefers `Module` classes if they exist, and never loads known uninstantiable classes that always exist (specifically, `Generator`).
weierophinney
added a commit
that referenced
this pull request
Nov 1, 2017
weierophinney
added a commit
that referenced
this pull request
Nov 1, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #72, non-namespaced classes can create issues within applications if
they conflict with a module. In particular,
Generatoris one (as theclass is non-instantiable via
new), but this can also happen in legacyapplications where a new module may exist under the same name as a
defined class.
This patch adds tests to ensure that the resolver prefers
Moduleclasses if they exist, and never loads known uninstantiable classes that
always exist (specifically,
Generator).Fixes #72